Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Missing queryFn" error when reloading with project openn #10894

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Fix https://github.com/enso-org/cloud-v2/issues/1451
    • Fix "Missing queryFn" error due to
      • This is done by providing a default value to the query. A more ideal solution may be to use the full query with the queryFn, but this is not an option here as the full query for this query requires a lot more info, some of which we don't have.

Important Notes

  • Test opening a top-level project and then refreshing
  • Test opening a project in a nested directory and then refreshing (to make sure the query is not being executed just because the corresponding row is visible)

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@somebody1234 somebody1234 added p-high Should be completed in the next sprint CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug --regression Important: regression g-dashboard labels Aug 27, 2024
isLoading,
isError,
} = reactQuery.useQuery({
const { data: projectState, isError } = reactQuery.useQuery({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove the loading state?

Copy link
Contributor Author

@somebody1234 somebody1234 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's now always false (at the type level too, which means we get lint errors if we don't remove isLoading) because of the initial value in the passive listener

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Aug 27, 2024
@mergify mergify bot merged commit bd3ebc5 into develop Aug 27, 2024
42 checks passed
@mergify mergify bot deleted the wip/sb/fix-reload-project branch August 27, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants