Akka-related startup improvements #10905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized that Akka Typed and Spray were not used **at all** yet there were in the list of dependencies. Additionally, the former would also show up in the list of Akka's library-extensions, initialized on startup.
Hardcoding a list of library extensions is not recommended but I don't see any other way of disabling expensive Serialization extension, which we don't seem to use anyway.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
JaroslavTulach
approved these changes
Aug 29, 2024
hubertp
requested review from
radeusgd,
jdunkerley,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
GregoryTravis
approved these changes
Aug 29, 2024
hubertp
added a commit
that referenced
this pull request
Aug 30, 2024
Recently (#10905) we got rid of 2 unnecessary dependencies. That seemed to have affected the generated native-image.
hubertp
added a commit
that referenced
this pull request
Aug 30, 2024
Recently (#10905) we got rid of 2 unnecessary dependencies. That seemed to have affected the generated native-image.
hubertp
added a commit
that referenced
this pull request
Sep 3, 2024
After #10905 we suddenly got a lot of (useless) logs from akka in project-manager and language-server. After some investigation it turned out that akka-typed had a special configuration to enable logging in akka using slf4j. As we don't need the whole library for that I only stole the configuration.
hubertp
added a commit
that referenced
this pull request
Sep 4, 2024
* Reduce akka logs in PM and LS After #10905 we suddenly got a lot of (useless) logs from akka in project-manager and language-server. After some investigation it turned out that akka-typed had a special configuration to enable logging in akka using slf4j. As we don't need the whole library for that I only stole the configuration. * nit * licensing * missing license files
4 tasks
jdunkerley
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Reduce akka logs in PM and LS After #10905 we suddenly got a lot of (useless) logs from akka in project-manager and language-server. After some investigation it turned out that akka-typed had a special configuration to enable logging in akka using slf4j. As we don't need the whole library for that I only stole the configuration. * nit * licensing * missing license files (cherry picked from commit 8b30998)
jdunkerley
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Reduce akka logs in PM and LS After #10905 we suddenly got a lot of (useless) logs from akka in project-manager and language-server. After some investigation it turned out that akka-typed had a special configuration to enable logging in akka using slf4j. As we don't need the whole library for that I only stole the configuration. * nit * licensing * missing license files (cherry picked from commit 8b30998)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Realized that Akka Typed and Spray were not used at all yet there were in the list of dependencies.
Additionally, the former would also show up in the list of Akka's library-extensions, initialized on startup.
Hardcoded
library-extensionslist which previously consisted of["akka.actor.typed.internal.adapter.ActorSystemAdapter$LoadTypedExtensions","akka.serialization.SerializationExtension$","akka.stream.SystemMaterializer$"]Important Notes
Typed extensions wasn't used at all. Serialization extension also seemed spurious and the system continues to work as before without it.