Wrap asset creation in a Promise #11396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation loading state
somebody1234
added
CI: No changelog needed
somebody1234
requested review from
PabloBuchu,
indiv0,
MrFlashAccount,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
somebody1234
commented
Oct 24, 2024
Comment on lines
+630
to
+636
| return useEventCallback( | ||
| async ( | ||
| name: string, | ||
| value: string, | ||
| parentId: DirectoryId, | ||
| parentPath: string | null | undefined, | ||
| ) => { |
There was a problem hiding this comment.
not sure if these shouldbe useMutation instead of useEventCallback. @MrFlashAccount wdyt?
somebody1234
commented
Oct 24, 2024
Comment on lines
+144
to
+158
| const newProjectRaw = useNewProject(backend, category) | ||
| const newProjectMutation = useMutation({ | ||
| mutationKey: ['newProject'], | ||
| mutationFn: async ([templateId, templateName]: [ | ||
| templateId: string | null | undefined, | ||
| templateName: string | null | undefined, | ||
| ]) => { | ||
| const parent = getTargetDirectory() | ||
| return await newProjectRaw( | ||
| { templateName, templateId }, | ||
| parent?.directoryId ?? rootDirectoryId, | ||
| parent?.path, | ||
| ) | ||
| }, | ||
| }) |
There was a problem hiding this comment.
@MrFlashAccount currently when we want to use the new hooks as a mutation they are wrapped into a mutation manually
|
also let me know if some of these functions should take a single object instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.or the Snowflake database integration, a run of the Extra Tests has been scheduled.