Add Write button to component menu #11523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
Frizi,
farmaazon,
kazcw,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
kazcw
reviewed
Nov 11, 2024
| import { ExternalId } from 'ydoc-shared/yjsModel' | ||
|
|
||
| /** Allows to recompute certain expressions (usually nodes). */ | ||
| export function useNodeExecution(projectStore: ProjectStore) { |
There was a problem hiding this comment.
This is instantiated by GraphNode and RecordControl, but looks like it should be shared state so that e.g. a node's recomputation status would be influenced by the execution environment's global recomputation status..
There was a problem hiding this comment.
Good catch, fixed
| @@ -255,14 +255,23 @@ export class ExecutionContext extends ObservableV2<ExecutionContextNotification> | |||
|
|
|||
| /** TODO: Add docs */ | |||
There was a problem hiding this comment.
The function signature is getting more complex; this would be a good time to add docs
There was a problem hiding this comment.
I just added a link to the function we call (it has a link to the LS docs).
kazcw
approved these changes
Nov 12, 2024
|
@MrFlashAccount @somebody1234 could you review this one, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #10486
write.button.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.