Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept input when clicking off the component #11541

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Closes #11360

accept-on-click.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@vitvakatu vitvakatu added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Nov 12, 2024
@vitvakatu vitvakatu self-assigned this Nov 12, 2024
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Nov 12, 2024
@jdunkerley jdunkerley added the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 12, 2024
@jdunkerley jdunkerley removed the CI: Keep up to date Automatically update this PR to the latest develop. label Nov 12, 2024
@mergify mergify bot merged commit 75733c5 into develop Nov 13, 2024
34 of 37 checks passed
@mergify mergify bot deleted the wip/vitvakatu/accept-changes-on-outer-click branch November 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking out of code edit mode on a component should commit the change not discard it
3 participants