Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_rows for Excel_Workbook.read. #11560

Merged
merged 4 commits into from
Nov 14, 2024
Merged

skip_rows for Excel_Workbook.read. #11560

merged 4 commits into from
Nov 14, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Nov 14, 2024

Pull Request Description

  • Adds skip_rows to Excel_Workbook.read.
  • Support for read by index.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Allow reading sheet by Index.
Allow skip rows to work on read.
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 14, 2024
@jdunkerley jdunkerley changed the title Wip/jd/small fixes skip_rows for Excel_Workbook.read. Nov 14, 2024
Copy link
Member

@AdRiley AdRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Be good to have a few tests that include headers too to show how that works with skip and limit. I guess skip is the interesting one.

@jdunkerley
Copy link
Member Author

Looks good. Be good to have a few tests that include headers too to show how that works with skip and limit. I guess skip is the interesting one.

Will be working on headers next - its an interesting question... should you read header then skip rows or vice versa!
Currently we do the later

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Nov 14, 2024
@mergify mergify bot merged commit d0f3d7f into develop Nov 14, 2024
36 of 37 checks passed
@mergify mergify bot deleted the wip/jd/small-fixes branch November 14, 2024 19:31
@AdRiley
Copy link
Member

AdRiley commented Nov 14, 2024

Looks good. Be good to have a few tests that include headers too to show how that works with skip and limit. I guess skip is the interesting one.

Will be working on headers next - its an interesting question... should you read header then skip rows or vice versa! Currently we do the later

Yeah. I think skip rows then read the header. Get rid of the rubbish people like to add before their tables in Excel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants