CodeMirror implementation of GraphNodeComment #11585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Separate parser for our flavor of Markdown from the CodeMirror integration; move the parser into ydoc-shared and use for Markdown line-wrapping. - Introduce our own version of yCollab extension; initially just the upstream version translated to Typescript and our code style. - Refactor CodeEditor.
Also a little refactoring in preparation for new implementation.
Eliminates Lexical dependency. Stacked on #11575 and #31607.
This reverts commit 7431384.
kazcw
added
the
CI: No changelog needed
This reverts commit 7431384.
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
5 tasks
farmaazon
approved these changes
Nov 21, 2024
Comment on lines
+67
to
+75
| { | ||
| markdown: '[Link text](<https://www.example.com/index.html>)', | ||
| expectedLinks: [ | ||
| { | ||
| text: 'Link text', | ||
| href: 'https://www.example.com/index.html', | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
You may consider adding cases for:
- Link with spaces and <>
- Link with spaces without <> (invalid case)
Or we may assume that those cases in image are sufficient. But then I would consider moving them here, as "link" seems to me more basic that images.
| '(a@b.cd)', | ||
| ], | ||
| neither: [ | ||
| 'https://💩.la/', |
kazcw
added
CI: Ready to merge
| @@ -48,7 +49,7 @@ export function AssetDocsContent(props: AssetDocsContentProps) { | |||
|
|
|||
| for (const statement of module.statements()) { | |||
| if (statement instanceof ast.MutableFunctionDef && statement.name.code() === 'main') { | |||
| return statement.documentationText() ?? '' | |||
| return normalizedMarkdownToStandard(statement.mutableDocumentationMarkdown().toJSON()) | |||
There was a problem hiding this comment.
why we turn this into a json? We expect a md string to parse it and display
There was a problem hiding this comment.
The toJSON method of Y.Text returns the unformatted text content as a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
CodeMirror-based implementation of GraphNodeComment; removes Lexical dependency.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.