Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB_Table.offset for SQLServer #12206

Merged
merged 32 commits into from
Feb 10, 2025
Merged

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jan 31, 2025

Pull Request Description

First implementation of DB_Table.offset for SQLServer.

Added a new SQLExpression.List to enable passing through the group by clauses and order by clauses as a single argument to the offset operation in database.

Currently, because SQLServer doesn't like order bys inside of subqueries there is a less than ideal workaround. We hsould probably revisit the order by logic for in database generally.

Enabled Table.new to specify data types for its columns.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 31, 2025
@AdRiley AdRiley force-pushed the wip/adr/add-sqlserver-offset branch 2 times, most recently from 0f84caa to 22626d9 Compare February 5, 2025 16:38
@AdRiley AdRiley changed the title Wip/adr/add sqlserver offset [WIP] Wip/adr/add sqlserver offset Feb 5, 2025
@AdRiley AdRiley force-pushed the wip/adr/add-sqlserver-offset branch from d0b8470 to 5c7bc52 Compare February 6, 2025 18:53
@AdRiley AdRiley changed the title [WIP] Wip/adr/add sqlserver offset Add DB_Table.offset fro SQLServer Feb 6, 2025
@AdRiley AdRiley changed the title Add DB_Table.offset fro SQLServer Add DB_Table.offset for SQLServer Feb 6, 2025
@AdRiley AdRiley marked this pull request as ready for review February 6, 2025 18:58
@AdRiley AdRiley removed the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 7, 2025
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@AdRiley AdRiley force-pushed the wip/adr/add-sqlserver-offset branch from 7f6ae9a to 6c07f59 Compare February 8, 2025 09:26
@AdRiley AdRiley merged commit 05d07bc into develop Feb 10, 2025
42 of 44 checks passed
@AdRiley AdRiley deleted the wip/adr/add-sqlserver-offset branch February 10, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants