-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB_Table.offset for SQLServer #12206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f84caa
to
22626d9
Compare
d0b8470
to
5c7bc52
Compare
radeusgd
reviewed
Feb 7, 2025
radeusgd
reviewed
Feb 7, 2025
radeusgd
reviewed
Feb 7, 2025
radeusgd
reviewed
Feb 7, 2025
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/IR/SQL_Expression.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 7, 2025
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Show resolved
Hide resolved
radeusgd
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
7f6ae9a
to
6c07f59
Compare
GregoryTravis
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
First implementation of DB_Table.offset for SQLServer.
Added a new SQLExpression.List to enable passing through the group by clauses and order by clauses as a single argument to the offset operation in database.
Currently, because SQLServer doesn't like order bys inside of subqueries there is a less than ideal workaround. We hsould probably revisit the order by logic for in database generally.
Enabled Table.new to specify data types for its columns.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.