Use Enso Font #7516

kazcw · 2023-08-08T01:32:29Z

Pull Request Description

Use the new Enso Font; also change the anti-aliasing logic to be based on device pixel ratio, rather than platform. This will improve the clarity of font rendering on Windows/Linux machines with high pixel densities.

Design reference:

Tested on various combinations of DPR/platform:

OS X, devicePixelRatio = 2 (should look similar to how we were already rendering mplus1 on OS X):

Windows, devicePixelRatio = 1.25 (should look similar to how we were already rendering mplus1 on this platform/DPR):

Linux, devicePixelRatio = 1 (should look similar to how we were already rendering mplus1 on this platform/DPR):

Important Notes

Style changes:

Use the Enso Font for code in Rust, replacing the DejaVu fonts.
Use the Enso Font in HTML: code in documentation, and error visualizations.
Change SpanWidgets from Bold to Extra Bold, to match the design.

Implementation improvements:

The new font download is cached (and Github-authenticated); this should eliminate a "rate limit" build failure I've
encountered in the past.
Clean up DocSection HTML rendering a bit.
Remove a CSS file that seems to have been superseded.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:
- Unit tests have been written where possible.
- If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Moving toward the new design: - New font replaces DejaVu Sans Mono. - Change bolded SpanWidgets to extra-bolded.

Use new font in: - Docs - Error visualizations

somebody1234

on the JS side it's mostly things being deleted, so no added code that needs to be reviewed

app/ide-desktop/lib/content/src/index.html

vitvakatu · 2023-08-08T08:24:57Z

build/build/src/ide/web/download.rs

+#[derive(Debug)]
+struct FixedContentUrl<D> {
+    url:        Url,
+    filename:   Box<Path>,


Out of curiosity, why Box<Path> is used everywhere instead of PathBuf?

It's a more specific type. PathBuf supports all the operations of Box<Path>, and additional operations. The additional operations offered by PathBuf are not appropriate for this value--it's the file part of a path, so e.g. it makes no sense to append anything to it. This is not a very important distinction in this case, but it also doesn't cost us anything here to be precise.

lib/rust/enso-font/src/lib.rs

farmaazon

The code is heavily duplicated. I think we could just extend ensogl-text-font-family crate and use it in the build script and enso-font crate.

app/ide-desktop/lib/content/src/index.html

farmaazon · 2023-08-08T08:01:03Z

build/build/src/ide/web/download.rs

+/// The `filename` parameter may be any path-safe string; it will only be seen when inspecting the
+/// cache.
+pub async fn get_file_from_cache_or_download(


Do you mean that filename will be used just as Cache key? This is how I've understood this, but I'm not 100% sure.

And what "path-safe" means? I deduce from the code below, that it rather should not be an absolute path.

Clarified the docs.

build/build/src/ide/web/fonts.rs

farmaazon · 2023-08-08T08:08:55Z

lib/rust/enso-font/Cargo.toml

@@ -0,0 +1,11 @@
+[package]
+name = "enso-enso-font"


This name is a bit amusing :) why not just "enso-font"?

Yeah, it sounds funny, but it is to avoid confusion: Since we prefix everything with enso-, enso-font would be what we call the Enso package for fonts (and actually after refactoring, that name is used). This is the Enso package for the Enso font.

lib/rust/ensogl/component/text/src/font/embedded/build.rs

lib/rust/enso-font/src/lib.rs

build/build/src/ide/web/download.rs

mwu-tow · 2023-08-10T11:34:08Z

build/build/src/ide/web/download.rs

@@ -0,0 +1,105 @@
+//! Support for downloading files.


I believe this effectively duplicates build/ci_utils/src/cache/download.rs, including the use-case of using octocrab to download the file?
I think these should be unified and be part of ide_ci::cache::download.

The Downloader is neat. I don't like the assumption of contents being constant by URL (as my use-case is a counterexample) — but perhaps the Key type could be provided by the Downloader as well?

Oh, I missed that module. Rewrote it to use the existing API.

build/build/src/ide/web/fonts.rs

build/build/src/ide/web/download.rs

build/build/src/ide/web/fonts.rs

lib/rust/enso-font/src/lib.rs

vitvakatu · 2023-08-14T07:54:21Z

QA Report: 🔴

Everything seems fine except for one issue. The cursor position does not match the actual place where the new characters are added/removed. This is not present on the most recent develop.

Kapture.2023-08-14.at.11.52.26.mp4

enso-bot · 2023-08-16T04:42:04Z

Keziah Wesley reports a new STANDUP for yesterday (2023-08-14):

Progress: Debugging an issue with cursor/selection logic. The PR does not change this logic, but I think the bug is exposed by using a non-monospace font for editable text. It should be finished by 2023-08-16.

Next Day: Next day I will be working on the #7516 task. Find the bug.

enso-bot · 2023-08-17T04:57:58Z

Keziah Wesley reports a new STANDUP for yesterday (2023-08-15):

Progress: Debugging wrong glyph counts. It should be finished by 2023-08-16.

Next Day: Next day I will be working on the #7516 task. Find the bug.

vitvakatu · 2023-08-17T16:31:29Z

The PR did not pass QA, so it can't be merged yet. I will check now.

vitvakatu · 2023-08-17T17:36:10Z

QA passed 📗

kazcw added 3 commits August 7, 2023 21:59

Use Enso font for monospace in Rust.

c076146

Moving toward the new design: - New font replaces DejaVu Sans Mono. - Change bolded SpanWidgets to extra-bolded.

Use Enso Font for code in HTML.

5b3c490

Use new font in: - Docs - Error visualizations

Improve antialiasing on non-Mac high-DPI displays.

96716a6

kazcw self-assigned this Aug 8, 2023

Fix confusing name.

8c5b224

kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Aug 8, 2023

kazcw added 2 commits August 8, 2023 05:18

Lint.

8fd92e3

Update test.

29a200f

kazcw marked this pull request as ready for review August 8, 2023 07:14

kazcw requested review from PabloBuchu, indiv0, somebody1234, MichaelMauderer, farmaazon, vitvakatu, Frizi, mwu-tow and JaroslavTulach as code owners August 8, 2023 07:14

somebody1234 approved these changes Aug 8, 2023

View reviewed changes

app/ide-desktop/lib/content/src/index.html Show resolved Hide resolved

JaroslavTulach approved these changes Aug 8, 2023

View reviewed changes

vitvakatu approved these changes Aug 8, 2023

View reviewed changes

farmaazon requested changes Aug 8, 2023

View reviewed changes

Review.

e14fcc5

kazcw linked an issue Aug 9, 2023 that may be closed by this pull request

Use new Enso font #7197

Closed

kazcw added 3 commits August 9, 2023 15:58

Clean up Font Registry

d44c907

Simplify.

81d211b

Fix.

b7f3911

kazcw marked this pull request as draft August 9, 2023 16:07

kazcw marked this pull request as ready for review August 9, 2023 16:07

Fix

840c344

farmaazon self-requested a review August 10, 2023 07:06

farmaazon approved these changes Aug 10, 2023

View reviewed changes

build/build/src/ide/web/download.rs Outdated Show resolved Hide resolved

mwu-tow suggested changes Aug 10, 2023

View reviewed changes

kazcw added 3 commits August 10, 2023 17:15

Review.

a9cad85

Review.

fe90c72

Simplify font registry.

cf2cbbb

kazcw marked this pull request as draft August 10, 2023 20:02

kazcw marked this pull request as ready for review August 10, 2023 20:02

mwu-tow approved these changes Aug 11, 2023

View reviewed changes

kazcw added 3 commits August 17, 2023 14:48

Disable ligatures.

3b8381a

Merge remote-tracking branch 'origin/develop' into enso-font

31f197b

Merge remote-tracking branch 'origin/develop' into enso-font

6dbc226

kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Aug 17, 2023

vitvakatu removed the CI: Ready to merge This PR is eligible for automatic merge label Aug 17, 2023

Fix test

f128ccd

vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Aug 17, 2023

mergify bot merged commit 1dfdee5 into develop Aug 17, 2023
24 checks passed

mergify bot deleted the wip/kw/enso-font branch August 17, 2023 18:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Enso Font #7516

Use Enso Font #7516

kazcw commented Aug 8, 2023 •

edited

Loading

somebody1234 left a comment •

edited

Loading

vitvakatu Aug 8, 2023

kazcw Aug 9, 2023

farmaazon left a comment

farmaazon Aug 8, 2023

kazcw Aug 9, 2023

farmaazon Aug 8, 2023

kazcw Aug 9, 2023 •

edited

Loading

mwu-tow Aug 10, 2023

kazcw Aug 10, 2023

vitvakatu commented Aug 14, 2023

enso-bot bot commented Aug 16, 2023

enso-bot bot commented Aug 17, 2023

vitvakatu commented Aug 17, 2023

vitvakatu commented Aug 17, 2023

Use Enso Font #7516

Use Enso Font #7516

Conversation

kazcw commented Aug 8, 2023 • edited Loading

Pull Request Description

Important Notes

Checklist

somebody1234 left a comment • edited Loading

Choose a reason for hiding this comment

vitvakatu Aug 8, 2023

Choose a reason for hiding this comment

kazcw Aug 9, 2023

Choose a reason for hiding this comment

farmaazon left a comment

Choose a reason for hiding this comment

farmaazon Aug 8, 2023

Choose a reason for hiding this comment

kazcw Aug 9, 2023

Choose a reason for hiding this comment

farmaazon Aug 8, 2023

Choose a reason for hiding this comment

kazcw Aug 9, 2023 • edited Loading

Choose a reason for hiding this comment

mwu-tow Aug 10, 2023

Choose a reason for hiding this comment

kazcw Aug 10, 2023

Choose a reason for hiding this comment

vitvakatu commented Aug 14, 2023

enso-bot bot commented Aug 16, 2023

enso-bot bot commented Aug 17, 2023

vitvakatu commented Aug 17, 2023

vitvakatu commented Aug 17, 2023

kazcw commented Aug 8, 2023 •

edited

Loading

somebody1234 left a comment •

edited

Loading

kazcw Aug 9, 2023 •

edited

Loading