Editing the node is not changing the placeholders and widgets #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
hubertp
reviewed
Aug 16, 2023
| @@ -250,6 +250,7 @@ public void onReturnExceptional(VirtualFrame frame, Throwable exception) { | |||
| } | |||
| } | |||
|
|
|||
| @CompilerDirectives.TruffleBoundary | |||
There was a problem hiding this comment.
Shouldn't this be on setExecuted instead?
Comment on lines
+572
to
+574
| call <- | ||
| if (Types.isPanic(value.getType)) Option(value.getCallInfo) | ||
| else Option(value.getCallInfo).orElse(Option(value.getCachedCallInfo)) |
There was a problem hiding this comment.
I know that this logic has been here already but it kind of looks weird that first we ask for call info and if missing we are asking for the cached value. I would expect the opposite to happen.
There was a problem hiding this comment.
This logic covers the case when the user comes back from the function (pops the execution frame). In this case, the expression does not have the call info because the result was cached and no function was called, but contains a cached call info.
I agree that it's weird but it always breaks some other cases when I try to come up with a workaround.
hubertp
approved these changes
Aug 18, 2023
mergify
bot
deleted the
wip/db/7462-editing-the-node-is-not-changing-the-placeholders-and-widgets-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #7462
Important Notes
enso-7462.mp4
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.