Rework ide-desktop CI

[somebody1234]

Pull Request Description

Refactors ide-desktop CI to move all the logic to JS. This should allow management of JS linting (almost) fully within the JS source tree.

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[indiv0]

Could you expand on what "This should allow management of JS linting (almost) fully within the JS source tree." means? Or rather, do you have an example of the benefit this provides?

[somebody1234]

well... the build script has been changed to run npm run lint - which should mean, in the future all that needs to be done would be to edit the "lint" npm script to add tasks to/remove tasks from/edit/fix JS linting. not sure this is that much of a benefit though

[somebody1234]

for me ./run lint seems to still be working correctly, and it's running npm run lint in the right directory (as expected), which in turn does seem to run npm install and npm run typecheck and npx eslint . as expected

[indiv0]

QA passed! Looks like there's an engine CI failure though :)

Scenarios

• ✅ ./run git-clean && ./run lint catches error

• ✅ ./run lint succeeds when no error

[somebody1234]

i'll try rerunning - @indiv0 note that it does need an approving review before it can be merged though, because of the package.json change

[indiv0]

Thanks for the note. Approved :)