-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forceCreate
from backend requests; minor bugfixes
#9074
Conversation
99c801f
to
980f490
Compare
…org/enso into wip/sb/remove-force-create
@somebody1234 I guess I need ask you for help. I tried introducing new
|
not too sure about this. it's possible that it's because React Strict mode runs React Effects twice... i'll have to take a look.
uh oh... will take a look. |
@PabloBuchu i think i've found what's wrong, haven't really tested though |
forceCreate
from backend requestsforceCreate
from backend requests; minor bugfixes
…org/enso into wip/sb/remove-force-create
hmm. actually there's one more issue that i might want to add - specifically: |
finally got around to it (among some other fixes) |
Pull Request Description
forceCreate
parameter from backend requestsdownload
module that already exists to download the app...no:
,has:
,label:
,-label:
,description:
,-description:
(and their corresponding autocomplete entries)"
andAssetIcon
Important Notes
Screenshots
Collapsed folder:
Expanded folder:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.