Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forceCreate from backend requests; minor bugfixes #9074

Merged
merged 26 commits into from
Feb 26, 2024

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Feb 15, 2024

Pull Request Description

  • Remove unused forceCreate parameter from backend requests
  • Also undo bad change to behavior of sorting assets:
  • Fix https://github.com/enso-org/cloud-v2/issues/910
    • Closing a project now doesn't close other projects.
    • Unable to properly test, as I cannot get the second project to open
  • Fix https://github.com/enso-org/cloud-v2/issues/908
    • Use the download module that already exists to download the app...
  • Add correct arrow icon for collapsing/expanding folders
    • Turns out this icon had always existed, and I just didn't see it for the longest time
  • Hide irrelevant parts of search bar on Local Backend
    • The row of labels
    • no:, has:, label:, -label:, description:, -description: (and their corresponding autocomplete entries)
    • Also change text to say "Type to search for projects." because the other asset types mentioned do not (and will never) exist on the Local Backend.
  • Fix search bar eating up " and keypresses
  • Fix icons for Data Links and Secrets being swapped in AssetIcon

Important Notes

Screenshots

Collapsed folder:
image

Expanded folder:
image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-chore Type: chore g-dashboard labels Feb 15, 2024
@PabloBuchu
Copy link
Contributor

@somebody1234 I guess I need ask you for help. I tried introducing new Scheduled state. This state is intermediate between Created|Closed and OpenInProgress. I added Scheduled to as you can see in my commit but:

  • when I open project the request is being issued twice: 1st with success and project state is Scheduled and immediately after which results in 500 (cause conditionals on our db fails). I am guessing there is somewhere a conditional which retries opening if project is not in OpenInProgress
  • when trying to close project in Scheduled no request is being sent

@somebody1234
Copy link
Contributor Author

which retries opening if project is not in OpenInProgress

not too sure about this. it's possible that it's because React Strict mode runs React Effects twice... i'll have to take a look.

when trying to close Scheduled project no request is being sent.

uh oh... will take a look.

@somebody1234
Copy link
Contributor Author

@PabloBuchu i think i've found what's wrong, haven't really tested though

@somebody1234 somebody1234 changed the title Remove forceCreate from backend requests Remove forceCreate from backend requests; minor bugfixes Feb 18, 2024
@somebody1234
Copy link
Contributor Author

hmm. actually there's one more issue that i might want to add - specifically:
the dashboard should probably also be switching to presigned urls for downloading files.
and it's a small enough change that it probably belongs in this PR

@somebody1234
Copy link
Contributor Author

finally got around to it (among some other fixes)

@PabloBuchu PabloBuchu added the CI: Ready to merge This PR is eligible for automatic merge label Feb 26, 2024
@mergify mergify bot merged commit 65f66fa into develop Feb 26, 2024
24 of 26 checks passed
@mergify mergify bot deleted the wip/sb/remove-force-create branch February 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-chore Type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants