Support privacy improvements for Google Analytics#55
Open
mthmulders wants to merge 1 commit intoenten:masterfrom
Open
Support privacy improvements for Google Analytics#55mthmulders wants to merge 1 commit intoenten:masterfrom
mthmulders wants to merge 1 commit intoenten:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests copies the internal Google Analytics template that ships with Hugo 0.41 and higher. It supports a few improved privacy options.
Alternatively, instead of copying (and slightly modifying it), we could do
But this does not work with Hyde currently. It would mean that the Google Analytics key needs to move:
This would break for existing users of Hyde, so it might or might not be a good idea. The benefit is that Hyde will automatically use improvements in the Hugo built-in Google Analytics integration, the drawback is that users need to update their config.