Skip to content

export getWallet, ensure it works + is exampled #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Apr 16, 2024

in the example, it was unclear where getWallet come from.

This PR

  • ensures getWallet is importable
  • changes tests to use import
  • changes Example code
  • changes the inline docs to be true (only takes a string)

@mixmix
Copy link
Contributor Author

mixmix commented Apr 16, 2024

What I don't know:

  • why tests are not passing locally
  • why there ./README.md is a duplicate of ./docs/README.md
  • are the docs generated from inline comments? (couldn't see an npm script for it)

@frankiebee
Copy link
Contributor

What I don't know:

  • why tests are not passing locally

  • why there ./README.md is a duplicate of ./docs/README.md

  • are the docs generated from inline comments? (couldn't see an npm script for it)

Tesser not running locally correctly because we rely on docker dot docs/Readme.md is a generated file. We should put a disclaimer that those docs come from a tool it should be in the package.json file I guess also we could ignore them?

@mixmix mixmix changed the title export getWallet, ensure it works + is exampled DRAFT: export getWallet, ensure it works + is exampled Apr 17, 2024
@mixmix mixmix requested a review from frankiebee April 17, 2024 02:01
@mixmix mixmix marked this pull request as draft April 17, 2024 02:02
@mixmix mixmix changed the title DRAFT: export getWallet, ensure it works + is exampled export getWallet, ensure it works + is exampled Apr 17, 2024
@mixmix
Copy link
Contributor Author

mixmix commented Apr 24, 2024

I'm gonna close this, got a mega branch working on this and other things

@mixmix mixmix closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants