add github-pages workflow #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
commented
Jul 1, 2024
Comment on lines
+32
to
+33
| # TODO: uncomment this before merge | ||
| # if: github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
TODO - this will guard against whatever PRs deploying.
I want to test deploy so this is temp disabled
Suggested change
| # TODO: uncomment this before merge | |
| # if: github.ref == 'refs/heads/main' | |
| if: github.ref == 'refs/heads/main' |
mixmix
commented
Jul 1, 2024
| - main | ||
| tags: | ||
| - 'v*.*.*' | ||
| - '!v*.*.*-*' |
There was a problem hiding this comment.
protect against deploying RC candidates like v0.2.0-dev or v0.2.0-2
mixmix
commented
Jul 1, 2024
| tags: | ||
| - 'v*.*.*' | ||
| - '!v*.*.*-*' | ||
| pull_request: |
There was a problem hiding this comment.
this means PRs run generate:docs - I guess this is important / good so we know if our production docs are gonna get wrecked?
|
Couple of questions:
|
|
@frankiebee can you turn on GH-PAGES or give us the keys plz? |
frankiebee
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy the docs yo