Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frankie/i#376 tsc #400

Closed
wants to merge 5 commits into from
Closed

Frankie/i#376 tsc #400

wants to merge 5 commits into from

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Jul 17, 2024

Changes TS build:

  • use tsc (no build step)
  • change every relative import to specify file extension
    • this is a hard requirement of type: module ESM setup 😢
    • side-stepping would require a more sugary build-tool
  • trim the tsconfig.json down, leave important notes

The tests all pass, BUT I've not been able to yarn link it in to @entropyxyz/cli because dev is broken at the moment.... oh I should try it in main...

frankiebee and others added 2 commits July 16, 2024 13:34
…first no yarn script. sometimes works with yarn never works with tests
@mixmix mixmix marked this pull request as draft July 17, 2024 02:42
@mixmix
Copy link
Contributor Author

mixmix commented Jul 17, 2024

NOTE a lot of the ugliness of import { thing } from './utils/index.js' is because we have been leaning on the default CJS pattern of "yeah gimme a folder and I'll try the index.js file I guess".

If we re-work file/folder structure we can make it nicer like import { thing } from './utils.js'

Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the imports everywhere lets try to alias them?
https://www.typescriptlang.org/tsconfig/#paths
https://webreaper.dev/posts/tsconfig-paths-setup/

@frankiebee
Copy link
Contributor

closing in favor of #402

@frankiebee frankiebee closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-chain ugggh the hole proposal i have a dream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants