TIS-884/AWS S3 support through rutebanken-helpers/storage
#193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation specific and are not used outside it either
…entations for file handling
testower
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlobStoreServiceinterface to make it actually consern only abstractable storage related operationsBlobStoreServiceAWS S3 support is needed by Fintraffic's deployment of NSR. There will possibly be further similar adaptation in the future as well. Generally the same assumptions as we made with uttu apply here as well, so including multi-cloud support into one build is assumed to be OK.
All documentation has been updated accordingly. GCS support still uses the old
BlobStoreServiceimplementation and has been excluded from the shim on purpose as I personally have never worked on GCS, so verifying it would do the right thing is really hard. Otherwise the AWS bits are quite similar to what's in uttu, including Localstack based local dev environment.