Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract button component #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

LBPeterson
Copy link
Contributor

@LBPeterson LBPeterson commented Sep 23, 2024

Enveritas Front End 2024 Interview 2

Objective

Your task is to perform a code review for this pull request. The pull request aims to refactor various single-use buttons to align with our design system, ensuring consistency and reusability across the application.

Scenario

We have a codebase with multiple button styles in use. Our design team has been working to unify our visual language to provide a more consistent user experience. This pull request is a step towards that goal. Here are our design docs for the button, please use them as you conduct your code review: https://products.enveritas.org/design-system/components/button/

Pull Request

#2

Instructions:

  1. Clone the repo and become familiar with the main branch and the changes that the PR proposes in the extract-button-component branch.
  2. Review the Pull Request and prepare detailed code review feedback.
  3. Submit Your Review: While our team typically submits code review directly in Github, for interview purposes please submit your code review via Greenhouse. You will have received a link in your Second Technical Interview email invitation that will direct you to Greenhouse's submission platform.

We recognize that Greenhouse is not a typical format for submitting code reviews, so please submit your review in whichever format is easiest for you. Please do not comment directly on the pull request in GitHub.

Setup

npm install

// start the application locally
npm run dev

// run tests
npm run test

What to Expect Next

After submitting your review, you will be invited to a live interview where we will discuss your feedback in detail and ask you to make changes to the pull request and codebase in a live pair programming session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant