Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enveritas Front End 2024 Interview 2
Objective
Your task is to perform a code review for this pull request. The pull request aims to refactor various single-use buttons to align with our design system, ensuring consistency and reusability across the application.
Scenario
We have a codebase with multiple button styles in use. Our design team has been working to unify our visual language to provide a more consistent user experience. This pull request is a step towards that goal. Here are our design docs for the button, please use them as you conduct your code review: https://products.enveritas.org/design-system/components/button/
Pull Request
#2
Instructions:
main
branch and the changes that the PR proposes in theextract-button-component
branch.We recognize that Greenhouse is not a typical format for submitting code reviews, so please submit your review in whichever format is easiest for you. Please do not comment directly on the pull request in GitHub.
Setup
npm install // start the application locally npm run dev // run tests npm run test
What to Expect Next
After submitting your review, you will be invited to a live interview where we will discuss your feedback in detail and ask you to make changes to the pull request and codebase in a live pair programming session.