Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanitisers compilation in PR#113 #114

Closed
wants to merge 1 commit into from

Conversation

dcillera
Copy link
Contributor

@dcillera dcillera commented Sep 7, 2023

Compilation option for sanitisers added in cmake configuration

Copy link
Contributor

@tedjpoole tedjpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need a target_compile_options(...) for the bssl-compat library target

@dcillera
Copy link
Contributor Author

I think we also need a target_compile_options(...) for the bssl-compat library target

And target_link_options too?

@tedjpoole
Copy link
Contributor

No, target_link_options() is only needed on the executable targets utests-boring and utests-bssl-compat

Signed-off-by: Dario Cillerai <dcillera@redhat.com>
@tedjpoole
Copy link
Contributor

@dcillera do you want to continue with this PR, or do you think it would be better to start another using the work you subsequently did using arsenm/sanitizers-cmake?

@dcillera
Copy link
Contributor Author

dcillera commented Oct 4, 2023

@tedjpoole I think it's better to create a new one.

@tedjpoole
Copy link
Contributor

Superseded by #121

@tedjpoole tedjpoole closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants