Patch to remove hard coded -lcrypto from proxy-wasm-cpp-host on s390x #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy-wasm-cpp-host BUILD file adds the -lcrypto option to the link line if either --define=crypto=system is specified to bazel, or if building on s390x. This effectively means that on s390x, the -lcrypto linker option is *always* added and there's no way to remove it. This updated patch removes that special s390x case, so that -lcrypto is *not* added to the link line unless --define=crypto=system is specified, the same as for all other architectures. In the context of envoy-openssl, this means that proxy-wasm-cpp-host, along with everything else, gets linked against libbssl-compat.a rather than libcrypto.so, which is what we need. Signed-off-by: Ted Poole <tpoole@redhat.com>
jwendell
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy-wasm-cpp-host
bazel/BUILDfile adds the-lcryptooption to the link line if either--define=crypto=systemis specified to bazel, or if building on s390x. This effectively means that on s390x, the-lcryptolinker option is always added and there's no way to remove it.This updated patch removes that special s390x case, so that
-lcryptois not added to the link line unless--define=crypto=systemis specified, the same as for all other architectures. In the context of envoy-openssl, this means that proxy-wasm-cpp-host, along with everything else, gets linked againstlibbssl-compat.arather thanlibcrypto.so, which is what we need.