Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-6578 backport envoy PR#32093 #242

Closed
wants to merge 1 commit into from

Conversation

yxun
Copy link
Contributor

@yxun yxun commented Jul 29, 2024

This PR backports a fix for OSSM-6578. It was discussed in upstream istio/istio#49000

The related maistra/istio PR is : maistra/istio#1052

Signed-off-by: yxun <yuanlin.yxu@gmail.com>
@jwendell
Copy link
Member

@yxun The ordinary way of backing port commits from newer Envoy branches is to get them backported to the envoyproxy/envoy repository, release/v1.28 branch. Once merged there, it will show up in this fork when we perform a sync.

@jwendell
Copy link
Member

jwendell commented Jul 29, 2024

Also, when performing a backport, use git cherry-pick <original commit SHA>. Thus we will preserve the original metadata such as Author and Date.

@yxun yxun closed this Jul 29, 2024
@yxun
Copy link
Contributor Author

yxun commented Jul 29, 2024

Closed this. Track in envoyproxy/envoy#35480

@yxun yxun deleted the OSSM-6578 branch August 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants