Skip to content

Commit

Permalink
Refresh the version of hessian2-code dependency (#38005)
Browse files Browse the repository at this point in the history
Commit Message:

The new version includes
alibaba/hessian2-codec#37 that contains a fix
for one of the issues listeed in
#37911 (number 5 on the list).

TL;DR: the issue is that in hessian2-codec the same cc file is used as a
source for two different libraries. The code that depends on both of
those libraries at the same time might have an issue because of the same
source used several times.

Additional Description: Related to #37911

Risk Level: Low

Testing:

Tested that Envoy builds with introduced changes, additionally run unit
tests in `//test/extensions/common/dubbo/...`
`//test/extensions/filters/network/dubbo_proxy/...` and
`//test/extensions/filters/network/generic_proxy/codecs/dubbo/...`.
dubbo is the extension that uses hessian2 codec (the full test suite
will run as part of the PR checks as well).

Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

---------

Signed-off-by: Mikhail Krinkin <mkrinkin@microsoft.com>
  • Loading branch information
krinkinmu authored Jan 14, 2025
1 parent a5cf609 commit 7974086
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -865,13 +865,13 @@ REPOSITORY_LOCATIONS_SPEC = dict(
project_name = "hessian2-codec",
project_desc = "hessian2-codec is a C++ library for hessian2 codec",
project_url = "https://github.com/alibaba/hessian2-codec.git",
version = "e9bb36e206f2c5054b50d11f88bb1b95c77766f8",
sha256 = "82743dcbf2bd624a68eb2c0d54963ea87446eba4eb08c117744f0669ddc70786",
version = "6f5a64770f0374a761eece13c8863b80dc5adcd8",
sha256 = "bb4c4af6a7e3031160bf38dfa957b0ee950e2d8de47d4ba14c7a658c3a2c74d1",
strip_prefix = "hessian2-codec-{version}",
urls = ["https://github.com/alibaba/hessian2-codec/archive/{version}.tar.gz"],
use_category = ["dataplane_ext"],
extensions = ["envoy.filters.network.dubbo_proxy", "envoy.filters.network.generic_proxy", "envoy.generic_proxy.codecs.dubbo"],
release_date = "2022-10-10",
release_date = "2025-01-14",
cpe = "N/A",
license = "Apache-2.0",
license_url = "https://github.com/alibaba/hessian2-codec/blob/{version}/LICENSE",
Expand Down

0 comments on commit 7974086

Please sign in to comment.