Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: Add upstream.locality attribute to obtain upstream host locality #38024

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

expr: Add upstream.locality attribute to obtain upstream host locality #38024

wants to merge 5 commits into from

Conversation

gopkarthik
Copy link
Contributor

@gopkarthik gopkarthik commented Jan 15, 2025 •
edited
Loading

Commit Message: Add upstream.locality attribute to obtain upstream host locality information
Additional Description: Enables http wasm filter to also access this data
Risk Level: Low
Testing: Unit tests
Docs Changes: Added
Release Notes: None
Platform Specific Features: None

@gopkarthik
expr: Add upstream.locality attribute to obtain upstream host locality
5b3dd7a 
Signed-off-by: Gopi Krishna <kgopikrishna@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38024 was opened by gopkarthik.

see: more, trace.

@gopkarthik
format changes.
b40cc38 
Signed-off-by: Gopi Krishna <kgopikrishna@google.com>
@gopkarthik gopkarthik marked this pull request as ready for review January 16, 2025 12:42
@gopkarthik
compare values in unit test instead of pointers
8dbcb1e 
Signed-off-by: Gopi Krishna <kgopikrishna@google.com>
@gopkarthik
Copy link
Contributor Author

@wbpcode can you help review this attribute addition or assign to the right contact? Thank you! (Kuat, CEL maintainer, seems to be on leave till March).

@wbpcode wbpcode self-assigned this Jan 17, 2025
wbpcode
wbpcode previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Could you merge main and add a change log for this new feature? Thanks again.

/wait

@wbpcode wbpcode dismissed their stale review January 21, 2025 02:30

waiting change log and main merge.

@gopkarthik
Merge remote-tracking branch 'upstream/main' into locality-attribute
5a0d2e0 
Signed-off-by: Gopi Krishna <kgopikrishna@google.com>
@gopkarthik
Update changelog
9bf08ef 
Signed-off-by: Gopi Krishna <kgopikrishna@google.com>
@gopkarthik
Copy link
Contributor Author

LGTM. Thanks. Could you merge main and add a change log for this new feature? Thanks again.

Thank you! Done. Waiting for presubmit checks to complete.

@gopkarthik
Copy link
Contributor Author

/retest

@gopkarthik gopkarthik requested a review from wbpcode January 24, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbpcode wbpcode Awaiting requested review from wbpcode

At least 1 approving review is required to merge this pull request.

Assignees

@wbpcode wbpcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gopkarthik @wbpcode