Skip to content

Conversation

anuragagarwal561994
Copy link
Contributor

Commit Message: Adds support for slow_start config to client side wrr lb policy
Additional Description: Adds support in proto for slow start config for support in client side wrr for GRPC
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Copy link

Hi @anuragagarwal561994, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #40090 was opened by anuragagarwal561994.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #40090 was opened by anuragagarwal561994.

see: more, trace.

Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
@anuragagarwal561994 anuragagarwal561994 force-pushed the clientside-wrr-slowstart branch from 196dd87 to ccd4f75 Compare July 1, 2025 21:11
@anuragagarwal561994
Copy link
Contributor Author

Related Proposal for GRPC Implementation: grpc/proposal#498

Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
@anuragagarwal561994 anuragagarwal561994 force-pushed the clientside-wrr-slowstart branch from db95123 to cf7f22a Compare July 1, 2025 21:29
Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
@anuragagarwal561994 anuragagarwal561994 force-pushed the clientside-wrr-slowstart branch from 98e3419 to a842318 Compare July 1, 2025 23:03
@wbpcode
Copy link
Member

wbpcode commented Jul 2, 2025

I am OK to the API. But if we have no implementation for this, we may should mark it as unimplemented?

/wait

@anuragagarwal561994
Copy link
Contributor Author

@wbpcode sure how do I mark it unimplemented, this is my first contribution here so need some help.

I am also willing to add another MR for the same with the implementation of slow start config to client WRR, if possible please help me with how can I do the same.

@wbpcode
Copy link
Member

wbpcode commented Jul 2, 2025

You could add [#not-implemented-hide:] tag to mark it as unimplemented. You could find lots of examples about this tags in the /api.

But will prefer to wait the grpc/proposal#498 to be merged first. :)

Signed-off-by: anurag.ag <anuragagarwal561994@users.noreply.github.com>
@anuragagarwal561994 anuragagarwal561994 force-pushed the clientside-wrr-slowstart branch from 91cd6a0 to 464320b Compare July 2, 2025 09:08
@anuragagarwal561994
Copy link
Contributor Author

@wbpcode I have made the respective changes to indicate this as unimplemented

@wbpcode
Copy link
Member

wbpcode commented Jul 2, 2025

@wbpcode I have made the respective changes to indicate this as unimplemented

ping me at slack or github once the grpc approved your proposal. :)

Copy link

github-actions bot commented Aug 3, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 3, 2025
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 10, 2025
@anuragagarwal561994
Copy link
Contributor Author

@wbpcode can we re-open this MR, the proposal is ready and will be merged soon

@wbpcode wbpcode reopened this Sep 16, 2025
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Sep 16, 2025
@paul-r-gall
Copy link
Contributor

Instead of just slow_start_config, why don't we add the entire Round robin proto in here? that way you can pass the whole round robin proto to the underlying Round Robin LB that backs ClientSideWeightedRR.

@anuragagarwal561994
Copy link
Contributor Author

I think this can be done, if it will be easier to implement it in envoy what do you think @wbpcode

@nezdolik
Copy link
Member

friendly ping @wbpcode

Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@repokitteh-read-only repokitteh-read-only bot removed the api label Oct 6, 2025
@wbpcode wbpcode merged commit 55422dd into envoyproxy:main Oct 9, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants