Update Jaeger UI and service port according to docs for jaeger example #249
Conversation
adilhafeez
force-pushed
the
adil/fix_jaeger_ports
branch
from
ba03ad9
to
bce0902
Compare
adilhafeez
changed the title
| @@ -40,4 +40,4 @@ services: | |||
| environment: | |||
| - COLLECTOR_ZIPKIN_HOST_PORT=9411 | |||
| ports: | |||
| - "${PORT_UI:-10000}:16686" | |||
| - "${PORT_UI:-16686}:16686" | |||
There was a problem hiding this comment.
this is correct as its not being proxied so makes more sense to expose the default port in this case.
it would also ensure it matches what is written in the docs
|
@adilhafeez you will need to update the listener port in envoy.yaml also |
@phlax just pushed another change. This change updates envoy with 10000 port and also updates rst file with console output. |
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Adil Hafeez <adil@katanemo.com>
Signed-off-by: Adil Hafeez <adil@katanemo.com>
Signed-off-by: Adil Hafeez <adil@katanemo.com>
|
nice, thanks @adilhafeez you will need to fix DCO now tho |
adilhafeez
force-pushed
the
adil/fix_jaeger_ports
branch
from
76ad2d6
to
28094b7
Compare
|
@phlax do you think it's a bad idea to link the screenshot in rst file? |
|
screenshot is fine but it will need to be added as an artefact - see the opentelemetry example for how to do that |
Signed-off-by: Adil Hafeez <adil@katanemo.com>
Signed-off-by: Adil Hafeez <adil@katanemo.com>
There was a problem hiding this comment.
lgtm, thanks @adilhafeez - really nice
as an aside we need to get docs build previews working in this repo
Default ports for jaeger and envoy service are incorrect in docker-compose file. In docs jager UI is set at 16686 and service's port is set to 8000
This code change updates ports according to docs.
Jaeger UI showing traces,
