golang-http: update example to adapt latest break change #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For behavior change:
Change ``OnLogDownstreamStart``, ``OnLogDownstreamPeriodic`` and ``OnLog`` methods so that user can get the request/response's
headers and trailers when producing access log.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
phlax
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
@spacewander changes lgtm, but currently the golang examples arent tested
the reason for this is that the go.mod setup was a bit hacky - involving referencing modules at ../../../../go.mod type of thing - my limited attempts to resolve when i moved the examples here didnt work out
any help getting this back working would be really appreciated
|
@phlax |
|
i think its not there because i removed it - im not sure the example works correctly - but i can try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For behavior change:
Change
OnLogDownstreamStart,OnLogDownstreamPeriodicandOnLogmethods so that user can get the request/response's headers and trailers when producing access log.