Fixes #965
Merged
Fixes #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Add implode
stwalkerster
requested changes
Aug 18, 2024
There was a problem hiding this comment.
One more thing (paperwork mostly!) - did you happen to check if this solves #794, or is there still more to deal with before we upgrade to 5.x? (I'm not asking you to do this, I'm just curious if we can close that issue after this PR is merged)
Co-authored-by: Simon Walker <github@stwalkerster.co.uk>
I didn't check the rest of it, it's just you mentioned implode on the issue, and I realised that the same fix for count can be done for impode |
stwalkerster
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Michael's PR #964. Remove version from docker-compose which is obsolete. Add count as a Smarty plugin so it continues working if Smarty is updated
EDIT: Just realised the Smarty issue is part of #794