ENYO-2533: Move deferred reset & refresh logic to VDR

NewDataList has some logic to defer refreshing and resetting when
the list is not showing.

This logic would apply equally to VirtualDataRepeater, so we'll
move it there.

Enyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)

src/NewDataList.js

@@ -323,57 +323,26 @@ module.exports = kind({
 	/**
 	* @private
 	*/
-	showingChangedHandler: kind.inherit(function (sup) {
-		return function () {
-			if (this.needsReset) {
-				this.reset();
-			}
-			else if (this.needsRefresh) {
-				this.refresh();
-			}
-			return sup.apply(this, arguments);
-		};
-	}),
+	collectionResetHandler: function () {
+		this.calcBoundaries();
+	},
 
 	/**
 	* @private
 	*/
-	refresh: kind.inherit(function (sup) {
-		return function () {
-			if (this.getAbsoluteShowing()) {
-				if (arguments[1] === 'reset') {
-					this.calcBoundaries();
-				}
-				this.needsRefresh = false;
-				sup.apply(this, arguments);
-			}
-			else {
-				this.needsRefresh = true;
-			}
-		};
-	}),
-
-	/**
-	* @private
-	*/
-	reset: kind.inherit(function (sup) {
+	init: kind.inherit(function (sup) {
 		return function () {
-			var v;
-			if (this.getAbsoluteShowing()) {
-				v = (this.direction === 'vertical');
-				this.set('scrollTop', 0);
-				this.set('scrollLeft', 0);
-				this.set('vertical', v ? 'auto' : 'hidden');
-				this.set('horizontal', v ? 'hidden' : 'auto');
-				this.calculateMetrics();
-				this.calcBoundaries();
-				this.first = 0;
-				this.needsReset = false;
-				sup.apply(this, arguments);
-			}
-			else {
-				this.needsReset = true;
-			}
+			var v = (this.direction === 'vertical');
+
+			this.set('scrollTop', 0);
+			this.set('scrollLeft', 0);
+			this.set('vertical', v ? 'auto' : 'hidden');
+			this.set('horizontal', v ? 'hidden' : 'auto');
+			this.calculateMetrics();
+			this.calcBoundaries();
+			this.first = 0;
+
+			sup.apply(this, arguments);
 		};
 	})
 });

src/VirtualDataRepeater.js

@@ -25,9 +25,15 @@ module.exports = kind({
 	// reorderNodes: false,
 
 	reset: function () {
-		this.init();
-		this.destroyClientControls();
-		this.setExtent();
+		if (this.getAbsoluteShowing()) {
+			this.init();
+			this.destroyClientControls();
+			this.setExtent();
+			this._needsReset = false;
+		}
+		else {
+			this._needsReset = true;
+		}
 	},
 
 	init: function () {
@@ -64,15 +70,38 @@ module.exports = kind({
 			this.notify('numItems', pn, this.numItems);
 		}
 	},
-
-	refresh: function (immediate) {
-		if (!this.hasInitialized) return this.reset();
 
-		this.stabilizeExtent();
+	refresh: function () {
+		if (!this.hasInitialized) return this.reset();
 
-		this.doIt();
+		if (this.getAbsoluteShowing()) {
+			if (arguments[1] === 'reset' && typeof this.collectionResetHandler === 'function') {
+				this.collectionResetHandler();
+			}
+			this.stabilizeExtent();
+			this.doIt();
+			this._needsRefresh = false;
+		}
+		else {
+			this._needsRefresh = true;
+		}
 	},
 
+	/**
+	* @private
+	*/
+	showingChangedHandler: kind.inherit(function (sup) {
+		return function () {
+			if (this._needsReset) {
+				this.reset();
+			}
+			else if (this._needsRefresh) {
+				this.refresh();
+			}
+			return sup.apply(this, arguments);
+		};
+	}),
+
 	childForIndex: function(idx) {
 		return this.childrenByIndex[idx];
 	},