Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS OPEN SWE PR
Fixes: #4
Summary by cubic
Added support for saving and loading app settings in the database, including a new settings table and related methods.
🔧 This WIP PR enhances the database service by adding comprehensive settings persistence functionality, including methods to save and retrieve user settings from a dedicated SQLite table. The changes lay the groundwork for fixing project-wide issues related to settings storage and application state management.
🔍 Detailed Analysis
Key Changes
getSettings()andsaveSettings()methods to handle JSON serialization/deserialization of Settings objectssettingstable with key-value storage for application configurationinitialize()method to create the settings table alongside existing categories and url_items tablesTechnical Implementation
sequenceDiagram participant App as Application participant DB as DatabaseService participant SQLite as SQLite Database App->>DB: getSettings() DB->>DB: initialize() DB->>SQLite: SELECT value FROM settings WHERE key = 'settings' SQLite-->>DB: ResultSet DB->>DB: jsonDecode(value) DB-->>App: Settings object App->>DB: saveSettings(settings) DB->>DB: jsonEncode(settings.toJson()) DB->>SQLite: INSERT OR REPLACE INTO settings SQLite-->>DB: SuccessImpact
Created with Palmier