Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add processes endpoint #14

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Add processes endpoint #14

merged 10 commits into from
Feb 16, 2024

Conversation

geospatial-roman
Copy link
Collaborator

@geospatial-roman geospatial-roman commented Jan 3, 2024 •
edited
Loading

Relates to Issue #6

Adds /processes endpoint to query availabled openeo Processes from openeo-processes dask

@geospatial-roman geospatial-roman changed the title [WIP] Add processes endpoint Add processes endpoint Feb 15, 2024
@SerRichard
Copy link
Member

Yeah, minor comments, otherwise lgtm!

SerRichard
SerRichard reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@SerRichard SerRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to say add tests for collections, and then I realised I was reading the processes MR. Don't know if it was intentional or accidental to mix the two branches? :)

openeo_fastapi/client/collections.py Outdated Show resolved Hide resolved
openeo_fastapi/client/collections.py Outdated Show resolved Hide resolved
openeo_fastapi/client/collections.py Outdated Show resolved Hide resolved
openeo_fastapi/client/collections.py Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yml Outdated Show resolved Hide resolved
@SerRichard SerRichard mentioned this pull request Feb 15, 2024
Merged
SerRichard
SerRichard approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@SerRichard SerRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the dependencies might not be needed later as it's just an api implementation, i.e xvec for example, but lgtm and can be ignored for now

Base automatically changed from add-collections-endpoints to main February 16, 2024 11:18
@geospatial-roman geospatial-roman merged commit cd690e1 into main Feb 16, 2024
3 checks passed
@geospatial-roman geospatial-roman deleted the add-processes-endpoint branch February 16, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerRichard SerRichard SerRichard approved these changes

@GeraldIr GeraldIr Awaiting requested review from GeraldIr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geospatial-roman @SerRichard