Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #386 added generic to function type declaration of update… #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NHamata
Copy link

@NHamata NHamata commented Aug 5, 2021

Fixed issue #386

Description

in the file ./typings/index.d.ts I added generic parameter to function type declaration of updateIfCurrentPlugin as well as its first parameter schema.

Related Issue

issue #386

Motivation and Context

Typescript and mongoose require generics to be defined, or else it throws and error.
Fixed issue #386 added generic to function type declaration of update

How Has This Been Tested?

replicated issue using typescript environment, as two other commenters have noted. Error no longer occurs. Only the index.d.ts file was updated, so there should be no change overall implementation.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant