[송지민] 과제 제출 #5
Open
[송지민] 과제 제출 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunJongHun
reviewed
Nov 26, 2023
There was a problem hiding this comment.
swagger 설정을 따로 파일을 만들어서 하니 깔끔해서 좋은 것 같습니다!
swagger를 여러개 만드는 경우도 있더라구요! 그래서 이 방법이 좋아 보입니다👍
| }); | ||
| await this.userRepository.save(user); | ||
|
|
||
| console.log(user); |
There was a problem hiding this comment.
저도 자주 까먹는데 디버깅용 console.log() 삭제하는 습관을 들이면 좋을 것 같아요👍
| }) | ||
| createdAt: Date; | ||
| @DeleteDateColumn({ type: 'timestamp' }) | ||
| deletedAt?: Date | null; |
There was a problem hiding this comment.
보통 entity에 optional을 붙이기도 하나요?
optioanl을 붙이면 deletedAt Column이 있어도 되고 없어도 된다는 뜻이 되지 않나요?!
하지만 deletedAt Column은 User Entity에 필수로 보여서요!
| } | ||
|
|
||
| export class ResponseUserDto { | ||
| @Expose() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
끝