Add ability to customize response in case of error by passing callable object #15
Open
ysv wants to merge 6 commits intoeparreno:masterfrom
Open
Add ability to customize response in case of error by passing callable object #15ysv wants to merge 6 commits intoeparreno:masterfrom
ysv wants to merge 6 commits intoeparreno:masterfrom
Conversation
ysv
changed the title
ysv
changed the title
Author
|
@eparreno could you take a look please |
ysv
commented
Oct 17, 2019
| MissingAuthHeader => 'Missing Authorization header', | ||
| InvalidAuthHeaderFormat => 'Invalid Authorization header format' | ||
| } | ||
| message = error_message.fetch(error.class, 'Default') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are willing to use your gem in our stack but faced one limitation.
It's impossible to customize error messages because they are hardcoded in
Rack::JWT::Auth#return_error.Since we have convention of error response in our stack I would like to introduce feature for customizing error messages by passing on_error option into middleware initializer