Add ability to provide regexp instead of just substrings for exclude#29
Open
berkes wants to merge 1 commit intoeparreno:masterfrom
Open
Add ability to provide regexp instead of just substrings for exclude#29berkes wants to merge 1 commit intoeparreno:masterfrom
berkes wants to merge 1 commit intoeparreno:masterfrom
Conversation
This is another go at eparreno#23, Where we make it a little more flexible by allowing either the old string version or a now newly introduced regxp. This is fully backwards compatible.
berkes
commented
Nov 30, 2021
| unless x.start_with?('/') | ||
| # Perhaps surprisingly, Regexp#inspect actually produces the more | ||
| # natural version of the string than #to_s. | ||
| as_s = x.is_a?(Regexp) ? x.inspect : x |
Author
There was a problem hiding this comment.
I'm not entirely sure about this. %r{stati+} turns into /stati+ so this always passes for Regexp. Which is probably not what we want. We could check for /\/stati in case of a regexp, but it becomes icky quite fast.
Do we want to check if it starts with a / for regexp at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another go at #23,
Where we make it a little more flexible by allowing either the old
string version or a now newly introduced regxp.
This is fully backwards compatible.