Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Invalidate Queries when changes happen to the group #106

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

alexrisch
Copy link
Collaborator

@alexrisch alexrisch commented Jun 20, 2024

Removed unused conversations code
Moved add member to mutation
Added helper functions for queries
Added handling for group stream to manage invalidating specific queries
Added handling to display metadata changes

Screen.Recording.2024-06-20.at.1.04.06.PM.mov

Removed unused conversations code
Moved add member to mutation
Added helper functions for queries
Added handling for group stream to manage invalidating specific queries
Added handling to display metadata changes
expect(invalidateGroupNameQuery).toHaveBeenCalledWith(account, topic);
});

it("should invalidate group photo query if group photo is changed", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the admin also change/would you want to add that to the invalidation logic too?

Copy link

@daria-github daria-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes! 👏

@alexrisch alexrisch merged commit 61cc068 into feat/xmtp-groups-dash Jun 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants