-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Composer Glow Up / Changed Functionality #1513
Merged
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
54026ef
progress
technoplato 952b479
Merge branch 'main' into ml/group-composer-glowup
technoplato db9553b
dm flow working with new dm and existing dm
technoplato cc44c63
first ugly draft
technoplato f78c3bb
some cleanup
technoplato 8102c02
typescript/lint error fixes
technoplato 1728c8c
chips are in
technoplato b6419ad
progress
technoplato 99e3525
progress on search results list/todo list
technoplato a3d0d83
designs
technoplato 55814f5
fix group name
technoplato 4a9fb97
whoopsie
technoplato 9517160
typescript navigation errors
technoplato 5b29a45
remove hard coded input
technoplato ea59bf7
remove log
technoplato cd458c7
ignore noisy logs
technoplato 39474b6
Merge branch 'main' into ml/group-composer-glowup
technoplato f4824a4
yarn clean; bandaid android notification crash
technoplato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Navigation route inconsistency detected
The change to use "Conversation" in
ClickableText.tsx
aligns with the majority of navigation patterns in the codebase. However, there is still one instance using the old "NewConversation" route:features/conversation-list/conversation-list.screen.tsx:350
:navigation.navigate("NewConversation", {});
🔗 Analysis chain
Verify navigation flow changes.
The navigation destination has changed from "NewConversation" to "Conversation". Ensure this change is intentional and all related navigation flows have been updated accordingly.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 120
Script:
Length of output: 4641