Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: More chat fixes #1559

Merged
merged 4 commits into from
Jan 21, 2025
Merged

fix: More chat fixes #1559

merged 4 commits into from
Jan 21, 2025
+77 −33

Conversation

thierryskoda
Copy link
Collaborator

No description provided.

@thierryskoda thierryskoda requested a review from a team as a code owner January 21, 2025 16:52
@thierryskoda thierryskoda enabled auto-merge (squash) January 21, 2025 16:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Performance Comparison Report

  • Current: 064a732 - 2025-01-21 16:56:13Z
  • Baseline: main (bf099f2) - 2025-01-21 16:55:05Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Avatar Image 10 runs render 0.8 ms → 0.8 ms 1 → 1
Avatar Image 50 runs render 0.7 ms → 0.5 ms (-0.2 ms, -27.3%) 🟢 1 → 1
Empty Avatar 10 runs render 1.0 ms → 1.0 ms 1 → 1
Empty Avatar 50 runs render 0.9 ms → 0.8 ms (-0.0 ms, -4.7%) 1 → 1
Text Component with color prop - 10 runs render 0.6 ms → 0.9 ms (+0.3 ms, +50.0%) 🔴 1 → 1
Text Component with default props - 10 runs render 0.8 ms → 0.8 ms 1 → 1
Text Component with translation key - 10 runs render 0.4 ms → 0.4 ms 1 → 1
Text Component with weight and size - 10 runs render 0.7 ms → 0.8 ms (+0.1 ms, +14.3%) 1 → 1
Show details
Name Type Duration Count
Avatar Image 10 runs render Baseline
Mean: 0.8 ms
Stdev: 0.6 ms (79.1%)
Runs: 1 0 0 1 0 1 1 1 2 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 0 1 1 0 1 1 1 1 1
Warmup runs: 0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Avatar Image 50 runs render Baseline
Mean: 0.7 ms
Stdev: 0.5 ms (72.5%)
Runs: 1 0 1 1 0 1 0 1 0 0 0 1 1 1 1 1 0 1 1 0 1 1 0 1 1 1 1 1 1 1 1 1 0 1 1 0 0 1 0 0 1 0 1 1 1 0 1 1 1 0
Warmup runs: 1

Current
Mean: 0.5 ms
Stdev: 0.5 ms (105.1%)
Runs: 1 0 1 0 0 0 1 1 0 1 0 0 0 1 0 0 1 0 1 0 1 1 0 1 0 0 1 0 0 0 1 0 1 1 1 1 1 0 0 1 0 1 0 0 1 1 1 0 0 1
Warmup runs: 0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 10 runs render Baseline
Mean: 1.0 ms
Stdev: 0.0 ms (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Warmup runs: 2

Current
Mean: 1.0 ms
Stdev: 0.7 ms (66.7%)
Runs: 1 0 0 1 2 1 1 1 1 2
Warmup runs: 2		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Empty Avatar 50 runs render Baseline
Mean: 0.9 ms
Stdev: 0.4 ms (40.8%)
Runs: 1 1 1 1 1 0 1 1 1 1 1 1 1 0 1 1 1 1 1 0 0 1 1 1 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 1 0 1 0 1 1 1 1 1 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (47.3%)
Runs: 1 1 1 1 1 1 1 1 0 0 1 1 0 1 1 1 1 1 1 1 1 0 1 1 1 1 1 1 1 0 0 1 1 1 1 1 0 1 1 1 0 1 1 0 1 1 1 1 1 1
Warmup runs: 1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Render issues:
Text Component with color prop - 10 runs render Baseline
Mean: 0.6 ms
Stdev: 0.5 ms (86.1%)
Runs: 1 0 0 0 1 1 1 0 1 1
Warmup runs: 0

Current
Mean: 0.9 ms
Stdev: 0.3 ms (35.1%)
Runs: 0 1 1 1 1 1 1 1 1 1
Warmup runs: 0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Text Component with default props - 10 runs render Baseline
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 1 1 1 1 1 0 1 0
Warmup runs: 4

Current
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 0 1 1 1 1 1 0 1
Warmup runs: 3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Text Component with translation key - 10 runs render Baseline
Mean: 0.4 ms
Stdev: 0.5 ms (129.1%)
Runs: 0 1 0 0 1 0 1 0 1 0
Warmup runs: 1

Current
Mean: 0.4 ms
Stdev: 0.5 ms (129.1%)
Runs: 0 0 0 1 1 0 0 1 1 0
Warmup runs: 1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:
Text Component with weight and size - 10 runs render Baseline
Mean: 0.7 ms
Stdev: 0.5 ms (69.0%)
Runs: 1 1 1 0 1 0 1 1 1 0
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.4 ms (52.7%)
Runs: 1 1 1 1 1 1 1 0 0 1
Warmup runs: 1		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 94222fd

alexrisch
alexrisch reviewed Jan 21, 2025
View reviewed changes
features/conversation-requests-list/use-conversation-requests-list-items.tsx
@@ -15,7 +15,6 @@ export function useConversationRequestsListItem() {
} = useQuery({
...getUnknownConsentConversationsQueryOptions({
account: currentAccount!,
caller: "useConversationRequestsListItem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

@thierryskoda thierryskoda merged commit 4705649 into main Jan 21, 2025
8 of 9 checks passed
@thierryskoda thierryskoda deleted the ts/fixes-21-01-2025 branch January 21, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrisch alexrisch alexrisch approved these changes

@technoplato technoplato technoplato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thierryskoda @technoplato @alexrisch