This repository was archived by the owner on Jul 11, 2025. It is now read-only.
feat: New conversation composer + refactor and fix profile socials + many other chat related fixes #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Comparison ReportSignificant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
Render Count ChangesThere are no entries Render IssuesThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
queries/use-conversations-query.ts
Outdated
| }; | ||
|
|
||
| const getConversations = async ( | ||
| args: IArgs & { | ||
| // We want to track who's making new calls to the network | ||
| caller: string; | ||
| } | ||
| ) => { | ||
| ): Promise<ConversationWithCodecsType[]> => { |
queries/use-conversations-query.ts
Outdated
|
|
||
| const conversationsWithMembers = await Promise.all( | ||
| conversations.map(async (c) => { | ||
| const members = await c.members(); |
There was a problem hiding this comment.
export function fetchOrGetGroupMembers (args: {
account: string;
topic: ConversationTopic;
}): Promise {
const members = getGroupMembersQueryData({ account, topic });
if (!members) {
return fetchGroupMembers(args);
}
return members
}
queries/use-conversations-query.ts
Outdated
| // Map conversations list to an array of ConversationWithCodecsType by | ||
| // fetching members for each conversation | ||
|
|
||
| const conversationsWithMembers = await Promise.all( |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
24
to
26
| if (!members.length) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
The function currently returns undefined for empty arrays but the test expects it to throw an error. To maintain consistency with the test suite, this function should throw an Error with a descriptive message like Cannot generate hash for empty members array. This will also provide clearer feedback when invalid input is provided.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
thierryskoda
force-pushed
the
ml/optimistic-create-conversation
branch
2 times, most recently
from
5436f11 to
f2e15e5
Compare
…te and tdd the rest
… rules; time for ui
thierryskoda
force-pushed
the
ml/optimistic-create-conversation
branch
from
f2e15e5 to
654c1be
Compare
thierryskoda
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thierryskoda made this loom quickly going over the meat and potatoes https://www.loom.com/share/acc615ce8db0450ca6023dd83b07645e