Add check and warning for PMFs longer than the data #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
force-pushed
the
warn-long-pmf
branch
from
3a00243 to
2ef6f3d
Compare
seabbs
reviewed
Feb 24, 2025
| delays <- list(...) | ||
| flat_delays <- do.call(c, delays) | ||
| # Track which component each delay came from | ||
| delay_names <- rep(names(delays), vapply(delays, EpiNow2:::ndist, numeric(1))) |
There was a problem hiding this comment.
you dont need ::: for internal functions. This is throwing a valid linting issue
seabbs
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Looks good. The vast majority of the linting issues being thrown are from the linting change vs this PR so don't need to be addressed here.
My main comment is do we just need to check individual lengths or do we also need to check the lengths of combined delays (i.e. the reporting delay when it is a reporting delay and a incubation period)?
|
|
||
| # Check lengths and collect info about exceeding PMFs | ||
| pmf_longer_than_data <- vapply(flat_delays[np_delays], function(x) { | ||
| length(x$pmf) > nrow(data) |
There was a problem hiding this comment.
don't we need to also check if the total reporting delay is longer than the data or the case where two distributions are passed to the generation time (not sure this is something you can actually do?)
jamesmbaazam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #739.
Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request