Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

973: underprediction/overprediction/etc. fails if all observations are above/below the medians #974

Merged
merged 2 commits into from
Nov 4, 2024
Merged

973: underprediction/overprediction/etc. fails if all observations are above/below the medians #974

merged 2 commits into from
Nov 4, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 2, 2024

Description

This PR closes #973.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 2, 2024

lint failure is unrelated and due to
RcppCore/Rcpp#1341

seabbs
seabbs reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse
Copy link
Contributor

Left one comment suggesting to add your original example as a test. Was the original issue actually about values being above/below the median? Or was it ultimately something else?

@sbfnk sbfnk merged commit 0761099 into main Nov 4, 2024
8 of 9 checks passed
@sbfnk sbfnk deleted the crps-small-sample branch November 4, 2024 00:17
@sbfnk sbfnk mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikosbosse nikosbosse nikosbosse left review comments

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

underprediction/overprediction/etc. fails if all observations are above/below the medians
3 participants
@sbfnk @nikosbosse @seabbs