Skip to content

Comments

Task: Release v1.5.3#23

Merged
jonrandahl merged 4 commits intomainfrom
spike/fix-nil-items
Apr 1, 2025
Merged

Task: Release v1.5.3#23
jonrandahl merged 4 commits intomainfrom
spike/fix-nil-items

Conversation

@jonrandahl
Copy link
Contributor

@jonrandahl jonrandahl commented Apr 1, 2025

PR encompasses changes to improve the data handling and error control:

  • improved API request logging with query string information.
  • reordered rescue statements for improved error handling.
  • fix for nil item list bug.

- Fixes a bug that causes an error when the API returns a response with a nil item list by providing a default value of 0.
- Improves the logging of API requests by creating a formatted query string for logging purposes.
- Improves error handling by reordering the rescue block for `Faraday::ConnectionFailed` to ensure proper instrumentation of connection failures before raising the exception.
Increments the patch version cadence.
Updates the changelog to include details for the v1.5.3 release.
Copy link
Contributor

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonrandahl jonrandahl merged commit 2caa3d6 into main Apr 1, 2025
4 checks passed
@jonrandahl jonrandahl deleted the spike/fix-nil-items branch April 1, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants