Skip to content

Comments

Issue: 571-Implement accredited statistic logo#572

Merged
jonrandahl merged 24 commits intodevfrom
issue/571-implement-accredited-statistic-logo
Feb 6, 2026
Merged

Issue: 571-Implement accredited statistic logo#572
jonrandahl merged 24 commits intodevfrom
issue/571-implement-accredited-statistic-logo

Conversation

@jonrandahl
Copy link
Contributor

@jonrandahl jonrandahl commented Feb 5, 2026

This pull request introduces dynamically loaded accredited statistic logo by locale linked to a content block on the landing page specific to the accreditation and refactors the header styling and structure to ensure responsive layout with the new logo(s).

Specific to ticket #571

What's changed:

  • Implements dynamic loading of the accredited statistic logo based on the current locale, providing appropriate Welsh and English logos linked to content
  • Refactors the header styling and structure, including extracting header and footer styles, improving header responsiveness and styling consistency, to improve code organisation and maintainability

Additional changes:

  • Updates several tooling dependencies including caniuse-lite and baseline-browser-mapping
  • Updates the githooks for code quality checks, including pre-commit, post-commit, and pre-push hooks, to automate linting and testing processes locally.

- adds accredited official statistics logo in English and Welsh
- provides both PNG and SVG versions for flexibility
- supports accessibility and localisation requirements
- Adds a logo that links to the official statistics page.
- Improves user recognition of accredited statistics.
- Introduces translations for the 'Official Accredited Statistic' text.
- Ensures the text is available in both English and Welsh.
- Supports consistent messaging across the application.
- Moves the accredited statistic logo to the correct position in the header
- Improves visual layout by displaying the logo above the header proposition
- Ensures the logo is prominently displayed on all responsive viewports
- improves the accessibility of the skip to main content link
- ensures the skip link is visually prominent and easy to select when focussed
- adds a border and shadow to the cookie banner for better visibility
- increases the button padding for improved user interaction
- modifies common styles for consistency and better UI
- tidies css whitespace and rule formatting
- introduces styling for the accredited statistics logo
- improves responsive layout for header elements
- simplifies and standardises build and deployment processes as defined in other projects
- replaces shell scripts with a structured Makefile
- defines targets for common tasks like building, testing, and linting
- uses make's dependency management for efficient builds
- Cleans up accredited official statistics logo images by using recommended source from website.
- updates the accredited statistic logo url creation to link to the accredited statistics target on the home page.
- Introduce a section for accredited official statistics on the landing page.
- Display information and a link to the Office for Statistics Regulation.
- Includes both English and Welsh versions to cater to both languages.
- updates pre-commit hook to run rubocop for ruby linting
- updates post-commit hook to run tests and prevent broken commits
- updates pre-push hook to build and run docker image before push
- provides common functions and utilities for git hooks
- introduces the bin/dev script to manage application start-up
- allows the application to run using `overmind` or `hivemind`
- falls back to `foreman` if unavailable
- updates the `Makefile` to use the new start-up script
- updates rubocop configuration for code formatting
- enforces consistent spacing and comma styles for improved code readability
- applies stricter rules for array and hash literals
- moves header and footer override styles into separate files
- improves maintainability and organisation of style rules
- enhances header layout on smaller screens by using flexbox
- ensures header elements wrap and align correctly on mobile
- provides a more consistent user experience across devices
- Updates header styles to use common variables.
- Refactors the server boot information logging to use a single message string.
- Improves readability and maintainability of the logging output.
@jonrandahl
Copy link
Contributor Author

Screenshots to help review changes:

English Welsh
CleanShot 2026-02-05 at 17 26 29 CleanShot 2026-02-05 at 17 33 47
CleanShot 2026-02-05 at 17 39 24 CleanShot 2026-02-05 at 17 35 58

@jonrandahl jonrandahl self-assigned this Feb 5, 2026
@jonrandahl jonrandahl marked this pull request as ready for review February 5, 2026 17:48
Copy link
Contributor

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have a changelog entry? Otherwise looks good to me!

- add accredited official statistics logo and section to landing page
- provide locale-aware selection of logo assets in English and Welsh
- include Welsh translations for accredited official statistics section
- refine header and footer styling for improved responsiveness
- update cookie banner and skip link spacing for layout consistency
- inject build-time version to eliminate runtime HTTP requests
- improve start-up logging for clearer server boot information
@jonrandahl jonrandahl merged commit 326f219 into dev Feb 6, 2026
2 checks passed
@jonrandahl jonrandahl deleted the issue/571-implement-accredited-statistic-logo branch February 6, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants