-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Coinbase Advanced Pair Converter Plugin #271
Open
macanudo527
wants to merge
11
commits into
eprbell:main
Choose a base branch
from
macanudo527:pair_converters/implement_coinbase_advanced
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement Coinbase Advanced Pair Converter Plugin #271
macanudo527
wants to merge
11
commits into
eprbell:main
from
macanudo527:pair_converters/implement_coinbase_advanced
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macanudo527
changed the title
Implement Coinbase Advanced
Implement Coinbase Advanced Pair Converter Plugin
Dec 13, 2024
macanudo527
force-pushed
the
pair_converters/implement_coinbase_advanced
branch
from
December 13, 2024 02:03
b3516fd
to
666a713
Compare
orientalperil
suggested changes
Dec 13, 2024
macanudo527
force-pushed
the
pair_converters/implement_coinbase_advanced
branch
from
December 16, 2024 01:49
dff740f
to
433902e
Compare
orientalperil
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a replacement for the historic crypto pair converter plugin that is no longer available. I made use of the Coinbase Advanced API with help from a code sample provided by @orientalperil here
Testing
I have not tested this personally with the real Coinbase server. I'll try to work up a short test to see if calls work as expected.