fix(replaceType): handle array syntax #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4def217 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
henryqdineen
force-pushed
the
hqd-array-syntax
branch
from
9ad1c3d to
5080e22
Compare
eps1lon
reviewed
Dec 10, 2024
henryqdineen
force-pushed
the
hqd-array-syntax
branch
from
d1fabf3 to
8c90389
Compare
eps1lon
force-pushed
the
hqd-array-syntax
branch
from
6864a24 to
4def217
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that we encountered running the React 19 codemods that would result in incorrect types like:
I'm not sure if it's actually a bug in the recast printer but I think the solution here makes sense. We check if the parent is a
TSArrayTypeand add parenthesis add aTSParenthesizedTypewrapper if appropriate.