feat(db): use bincode for starknet_transactions
#1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another idea: looks like the migration doesn't fully use the available I/O bandwidth (at least with an NVMe SSD) and it's CPU bound. I think we could do the decompression/JSON parsing/bincode encoding/compression steps concurrently so that we use all available I/O bandwidth? The mainnet migration has been running for >2 hours for me and it's still busy re-encoding stuff (so not yet at |
|
|
kkovaacs
approved these changes
Mar 22, 2024
Mirko-von-Leipzig
approved these changes
Mar 23, 2024
sistemd
force-pushed
the
sistemd/bincode-instead-of-json
branch
2 times, most recently
from
70f571c to
f46d11a
Compare
CHr15F0x
approved these changes
Mar 25, 2024
sistemd
merged commit cbe4de5
into
sistemd/1843-split-receipts-and-events
12 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time as changing the format, I tried to optimize and clean up where I could. Let me know if I missed something.
Added DB versioning to the bincoded columns (tx, receipt, events).
This results in a 15GiB saving on Goerli, which is a 8.7% reduction. Maybe we should do this for the headers, too.
Last PR for #1843 before I can open the final big PR.