Skip to content

feat: exporting snapshot using CommitBlockInfoV2 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: exporting snapshot using CommitBlockInfoV2 #65

merged 1 commit into from
Feb 8, 2024

Conversation

zeapoz
Copy link
Member

@zeapoz zeapoz commented Feb 7, 2024

No description provided.

@zeapoz zeapoz requested a review from vbar February 7, 2024 11:11
@zeapoz zeapoz self-assigned this Feb 7, 2024
vbar
vbar reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@vbar vbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but now I see its on feat/boojum-support, which is already merged - shouldn't it get its own branch?

@zeapoz
Copy link
Member Author

zeapoz commented Feb 7, 2024

The change is fine, but now I see its on feat/boojum-support, which is already merged - shouldn't it get its own branch?

Well, the other two boojum PRs have been on this branch so I figured I would continue that trend, given that this one concludes the trifecta.

@vbar
Copy link
Collaborator

vbar commented Feb 7, 2024

The change is fine, but now I see its on feat/boojum-support, which is already merged - shouldn't it get its own branch?

Well, the other two boojum PRs have been on this branch so I figured I would continue that trend, given that this one concludes the trifecta.

I wonder if you can merge a merged branch again... I can't even pull it...

@zeapoz
Copy link
Member Author

zeapoz commented Feb 7, 2024

I wonder if you can merge a merged branch again... I can't even pull it...

Huh, works well on my machine, and since it's been done before I don't see any reason why it wouldn't work...

@zeapoz zeapoz merged commit 41c8406 into main Feb 8, 2024
@zeapoz zeapoz deleted the feat/boojum-support branch February 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbar vbar vbar approved these changes

Assignees

@zeapoz zeapoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeapoz @vbar