Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blob scaffolding #67

Merged
merged 9 commits into from
Mar 1, 2024
Merged

feat: blob scaffolding #67

merged 9 commits into from
Mar 1, 2024

Conversation

zeapoz
Copy link
Member

@zeapoz zeapoz commented Feb 27, 2024

This PR:

  • Implement scaffolding for new V3-format.
    • The format itself.
    • Switch for grabbing pubdata from calldata/blobs.
    • Switch which format to parse as, based on L1 block number.
  • Pubdata from calldata (V3).

Future work:

  • Pubdata from blobs.
  • Current layout is a bit awkward to work around when the formats share so much code in common, we should consider making something like an FSM instead.

@zeapoz zeapoz requested a review from vbar February 27, 2024 15:59
@zeapoz zeapoz self-assigned this Feb 27, 2024
vbar
vbar reviewed Feb 28, 2024
View reviewed changes
state-reconstruct-fetcher/src/l1_fetcher.rs Outdated Show resolved Hide resolved
state-reconstruct-fetcher/src/types/v3.rs Outdated Show resolved Hide resolved
state-reconstruct-fetcher/src/types/v3.rs Outdated Show resolved Hide resolved
@zeapoz zeapoz force-pushed the feat/blob-scaffolding branch from c08865c to a6c094f Compare March 1, 2024 09:13
@zeapoz zeapoz merged commit 189beef into main Mar 1, 2024
4 checks passed
@zeapoz zeapoz deleted the feat/blob-scaffolding branch March 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbar vbar vbar approved these changes

Assignees

@zeapoz zeapoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeapoz @vbar