feat: upgrade openapi-generator to latest version #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ctreatma
force-pushed
the
upgrade-openapi-generator
branch
from
3f4faef
to
0163e8d
Compare
ctreatma
force-pushed
the
upgrade-openapi-generator
branch
from
0163e8d
to
6231395
Compare
ctreatma
force-pushed
the
upgrade-openapi-generator
branch
from
183da80
to
318e828
Compare
|
This PR is included in version 0.33.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades openapi-generator to the latest version in order to pull in improvements to required field validation.
The latest version doesn't like the
allOfstructure we were using to add a custom description for interconnection metros:For now, I've added a patch to remove the custom description; as far as I can tell the existing structure is valid OpenAPI, and nesting the description under the allOf causes a new InterconnectionMetro model to be created. Removing the custom description resolves the issue without adding another thing for SDK users to keep track of.