Skip to content

fix: smarter validate attributes of type any #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: smarter validate attributes of type any #683

merged 1 commit into from
Nov 6, 2023

Conversation

soofstad
Copy link
Contributor

@soofstad soofstad commented Nov 1, 2023 •
edited
Loading

What does this pull request change?

  • A bit more robust handling of "any" type and validation
  • "any" is now considered a primitive type, which was needed for being able to update primitive values
  • Reorder a list of "if/elif" in validators.py, so that the special case of BlueprintAttributes get's picked out before "any" is picked as a primitive

Why is this pull request needed?

  • The validator did not allow users to update the "default" attribute in BlueprintAttribute with a primitive value

Issues related to this change:

none

@soofstad soofstad force-pushed the fix/dont-validate-attributes-of-type-any branch from 51b8b68 to 2d7a41a Compare November 1, 2023 08:51
@soofstad soofstad self-assigned this Nov 1, 2023
@soofstad soofstad marked this pull request as ready for review November 1, 2023 08:59
@soofstad soofstad requested a review from a team as a code owner November 1, 2023 08:59
@soofstad soofstad changed the title fix: don't validate attributes of type any fix: smarter validate attributes of type any Nov 1, 2023
eoaksnes
eoaksnes approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@eoaksnes eoaksnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

@soofstad soofstad merged commit 763ac1a into master Nov 6, 2023
@soofstad soofstad deleted the fix/dont-validate-attributes-of-type-any branch November 6, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eoaksnes eoaksnes eoaksnes approved these changes

Assignees

@soofstad soofstad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soofstad @eoaksnes