Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move reference_resolver into address_resolver #688

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

pbullhove
Copy link
Contributor

@pbullhove pbullhove commented Nov 7, 2023

What does this pull request change?

Similar as an older PR that was approved a month ago, but not merged.

This moved a the reference resolver into the address resolver and refactors it to be much more readable.

Why is this pull request needed?

Issues related to this change:

@pbullhove pbullhove force-pushed the refactor/move-reference-resolver branch from 4cbad2a to b8934ea Compare November 7, 2023 08:10
@pbullhove pbullhove changed the title refactor: move everything into address_resolver refactor: move reference_resolver into address_resolver Nov 7, 2023
@pbullhove pbullhove force-pushed the refactor/move-reference-resolver branch from 961b332 to b8934ea Compare November 7, 2023 08:24
@pbullhove pbullhove force-pushed the refactor/move-reference-resolver branch from 5281b66 to 71c7129 Compare November 7, 2023 09:12
@pbullhove pbullhove marked this pull request as ready for review November 7, 2023 09:28
@pbullhove pbullhove requested a review from a team as a code owner November 7, 2023 09:28
Copy link
Contributor

@soofstad soofstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

Copy link
Collaborator

@eoaksnes eoaksnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@pbullhove pbullhove merged commit c96bbc9 into master Nov 14, 2023
3 checks passed
@pbullhove pbullhove deleted the refactor/move-reference-resolver branch November 14, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants